Conversation
Raise MissingCommitError immediately for blank SHAs instead of attempting a pointless fetch. Include the SHA value in all MissingCommitError messages for easier debugging. Add track context (slug and synced_to_git_sha) to Sentry reports in UpdateTracksBuildStatusJob. Closes #8626 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8626
Summary
Git::Repository#lookup_committo raiseMissingCommitErrorimmediately for blank SHAs, avoiding a pointlessfetch!callMissingCommitErrormessages so the malformed value is visible in error reportstrack_slug,synced_to_git_sha) to Sentry reports inUpdateTracksBuildStatusJobso the offending track can be identified and the data fixed upstreamTest plan
MissingCommitErrorwithout callingfetch!lookup_committests continue to passtest/models/git/repository_test.rbpasses (10 runs, 0 failures)🤖 Generated with Claude Code